Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/689#discussion_r37623820
--- Diff:
framework/quota/src/org/apache/cloudstack/quota/constant/QuotaTypes.java ---
@@ -0,0 +1,92 @@
+// Licensed to the Apache Software Foundation (ASF) under one
+// or more contributor license agreements. See the NOTICE file
+// distributed with this work for additional information
+// regarding copyright ownership. The ASF licenses this file
+// to you under the Apache License, Version 2.0 (the
+// "License"); you may not use this file except in compliance
+// with the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing,
+// software distributed under the License is distributed on an
+// "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+// KIND, either express or implied. See the License for the
+// specific language governing permissions and limitations
+// under the License.
+package org.apache.cloudstack.quota.constant;
+
+import org.apache.cloudstack.usage.UsageTypes;
+
+import java.util.HashMap;
+
+public class QuotaTypes extends UsageTypes {
+ public static final int CPU_CLOCK_RATE = 15;
+ public static final int CPU_NUMBER = 16;
+ public static final int MEMORY = 17;
+
+ private Integer quotaType;
+ private String quotaName;
+ private String quotaUnit;
+ private String description;
+ private String discriminator;
+
+ public QuotaTypes(Integer quotaType, String name, String unit, String
description) {
+ this.quotaType = quotaType;
+ this.description = description;
+ this.quotaName = name;
+ this.quotaUnit = unit;
+ this.discriminator = "None";
+ }
+
+ public static HashMap<Integer, QuotaTypes> listQuotaTypes() {
+ final HashMap<Integer, QuotaTypes> quotaTypeList = new
HashMap<Integer, QuotaTypes>();
+ quotaTypeList.put(new Integer(RUNNING_VM), new QuotaTypes(new
Integer(RUNNING_VM), "RUNNING_VM", "Compute-Month", "Running Vm Usage"));
--- End diff --
Understanding the compatibility with the type declarations of existing
code, I can see no reason to avoid the constant pool and put unnecessary
pressure on the garbage collector by using ``new Integer()`` rather than
``Integer.valueOf()``.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
