Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/725#issuecomment-133457425
Maybe a little out of scope for this PR, I have been looking a bit at the
hierarchy. It contains a lot of primitives. somewhat related to our gson
problem (arrays of primitive types) those should be removed.
@kishankavala I see your point on serialisation testing. But it doesn't
mean that a simple test is useless. (no -1 for that) Let us think/search on
applicable tests.
Did you test this code in any way?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
