Github user bhaisaab commented on the pull request: https://github.com/apache/cloudstack/pull/685#issuecomment-134919051 Can you add some tests, we'll need to test it before merging. @DaanHoogland have you looked at it, since you had recently made some related changes or might have experience in the codebase around that? In general, LGTM. We definitely merge after you had added some tests.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---