Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/685#issuecomment-137254065
so now we are back to, "I would like to see two unit tests for
checkForKeyByPublicKey. The succes and the failure cases. I am not sure if this
check shows a very good pattern but that is out of scope for this PR. Other
then unit tests missing, LGTM." I won't stop stop this with a :-1: but I think
it can be augmented with more tests.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
