Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/775#issuecomment-138872339
@nitin-maharana, when I said that the String concatenation there might make
ACS vulnerable to SQL injection attacks, I did not mean that your PR did that.
What I meant was that the code that is there, even before your PR, is making
ACs vulnerable.
I just mentioned about the vulnerability here to register the thought, so
others can also think about the problem that might exist.
I do not know much of ACS DAOs, but if in other places such as VM API (in
which users have access), the same String concatenations are used that can be a
huge problem.
Besides that the code LGTM.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
