Github user DaanHoogland commented on the pull request:
https://github.com/apache/cloudstack/pull/775#issuecomment-140910285
@rafaelweingartner we keep growing methods and not writing unit tests. Thus
our code base is worsening in quality or at least in maintainability. However
trivial we should keep refactorring and adding unit test in order to prevent
things like "First the method is huge (around 100 lines), and second it is a
method that performs database access (it builds "queries" to retrieve data).
Maybe,...". I dont want to mis-quote you but am getting weary of all the
reasons not to write unit tests. There is a lot of valid reasons and we should
break through and focus on writing more (unit-)tests anyway (not discarding
integration tests on the way). So as you say let's refactor the method and add
the unit tests. even when trivial at the moment and discarding 90% of them
along the way we will not regret putting in the effort.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
