Github user mike-tutkowski commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/816#discussion_r39394113
--- Diff:
plugins/storage/volume/solidfire/src/org/apache/cloudstack/storage/datastore/util/SolidFireUtil.java
---
@@ -124,6 +132,22 @@
private final String _clusterAdminPassword;
public SolidFireConnection(String managementVip, int
managementPort, String clusterAdminUsername, String clusterAdminPassword) {
--- End diff --
Good catch, Wido. How's about I put that on my todo list (and open a PR
after this one)? It would end up changing a lot of lines of code in this PR
that might distract from the main intention of this work.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
