Github user mike-tutkowski commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/816#discussion_r39390674
--- Diff:
server/src/com/cloud/network/router/VirtualNetworkApplianceManagerImpl.java ---
@@ -1981,7 +1981,7 @@ private void createDefaultEgressFirewallRule(final
List<FirewallRule> rules, fin
// construct rule when egress policy is true. In true case for VR
we default allow rule need to be added
if (!defaultEgressPolicy) {
- systemRule =
String.valueOf(FirewallRule.FirewallRuleType.System);
+ // systemRule =
String.valueOf(FirewallRule.FirewallRuleType.System);
--- End diff --
While making changes in this file, I noticed that Eclipse was pointing out
that the variable systemRule was only written to (never read from). Instead of
removing the entire line, I just commented it out in case someone later wanted
to easily resume making use of this variable.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
