Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/714#issuecomment-140367124
Hi @DaanHoogland, what I don't understand is how travis compiled and 15
days ago @rafaelweingartner said that he forgot to push 1 file.
Looking at the history, we see the following:
So, perhaps the timeout occurred before the missing file was needed, so one
could not tell if it would have worked at all. Therefore we have to compile the
PRs and test them before LGTM.
I also don't get why @mike-tutkowski simply gave a LGTM without any
comment. Come on, guys... lets improve ACS, not make it worse.
In the past - not long ago - we had problems with HyperV, not even used in
our environment, and also with static fields not initialised properly that
caused systemVMs to not start at all. If I see a change of +4k line 380 files
in a tightly-coupled system like ACS, I would test it as much as I could before
saying anything.
@rafaelweingartner @pedro-martins : do you have a test environment?
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
