Github user mike-tutkowski commented on the pull request:
https://github.com/apache/cloudstack/pull/714#issuecomment-140392192
"In this particular case, how is possible to get 2 LGTM without even
compiling the project locally?"
I was depending on the info Daan refers to and, as such, did not build it
locally.
By the time I came into the picture with regards to this PR, it was mainly
a matter of looking through 361 files for changes to the name of a variable.
Not sure how verbose of a comment you'd like for that, but it looked reasonable
to me.
Perhaps we need to document on our Wiki exactly what needs to go into a
review (including comments).
A lot of reviews for PRs that I've seen have taken my approach here: The PR
submitter asked for another review, a reviewer took time to go through the code
online, but didn't compile because he/she expected asfbot's SUCCESS meant it
was OK from that standpoint, then wrote "LGTM."
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
