Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/908#issuecomment-145473615
Hi @remibergsma and @bvbharat,
Please have a look at my comment from 2 days ago. I mentioned that indeed
the change would create a regression. So this PR won't get merged with the
current change on the copy/copy_if_needed stuff.
I will change it back and also refactor the code of the copy() function,
which is not duplicate from the copy_if_needed.
Concerning the current way theVR is being configured - and having the
configuration applied every time update_config is called - I agree it's not
optimal.
Our plan is to stabilise all the VRs in the coming 2 weeks. If we get the
BVTs to work as expected, we will then move towards the next phase: refactor
the persistent configuration, which should be available for a 4.6.1 release.
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
