Github user wilderrodrigues commented on the pull request:
https://github.com/apache/cloudstack/pull/908#issuecomment-146148340
Hi @remibergsma @bvbharat @karuturi @DaanHoogland @borisroman @wido
@miguelaferreira
The VRRP code is again compliant with RVR and r-VPC, I just refactored the
copy method in order to avoid duplication.
Whilst trying to fix the cleanup I found out another bug: CLOUDSTACK-8935.
So, in order to get the cleanup working I had to add a remove routers in the
tearDown, otherwise the networks cannot be removed.
There is also a bug concerning the r-VPC and RVR default routes:
CLOUDSTACK-8934. As you can see, I created only one issue for both, but if you
think would be better we can split it.
The both issues mentioned above will be tackled in different PRs.
Tests were executed agains the following environment:
* Management Sever + MariaDB on CentOS 7.1
* KVM host on CentOS 7.1
Below the results for the tests that require hardware:
```
Create a redundant VPC with two networks with two VMs in each network ...
=== TestName: test_01_create_redundant_VPC_2tiers_4VMs_4IPs_4PF_ACL | Status :
SUCCESS ===
ok
Create a redundant VPC with two networks with two VMs in each network and
check default routes ... === TestName: test_02_redundant_VPC_default_routes |
Status : FAILED ===
FAIL
======================================================================
FAIL: Create a redundant VPC with two networks with two VMs in each network
and check default routes
----------------------------------------------------------------------
Traceback (most recent call last):
File
"/data/git/cs1/cloudstack/test/integration/component/test_vpc_redundant.py",
line 493, in test_02_redundant_VPC_default_routes
self.do_default_routes_test()
File
"/data/git/cs1/cloudstack/test/integration/component/test_vpc_redundant.py",
line 545, in do_default_routes_test
"Ping to outside world from VM should be successful"
AssertionError: Ping to outside world from VM should be successful
----------------------------------------------------------------------
Ran 2 tests in 3934.969s
FAILED (failures=1)
Test iptables default INPUT/FORWARD policy on RouterVM ... === TestName:
test_02_routervm_iptables_policies | Status : SUCCESS ===
ok
Test iptables default INPUT/FORWARD policies on VPC router ... ===
TestName: test_01_single_VPC_iptables_policies | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 2 tests in 1005.326s
OK
/tmp//MarvinLogs/test_routers_iptables_default_policy_5T12QU/results.txt
(END)
Create a VPC with two networks with one VM in each network and test nics
after destroy ... === TestName: test_01_VPC_nics_after_destroy | Status :
SUCCESS ===
ok
Create a VPC with two networks with one VM in each network and test default
routes ... === TestName: test_02_VPC_default_routes | Status : SUCCESS ===
ok
----------------------------------------------------------------------
Ran 2 tests in 1831.943s
OK
/tmp//MarvinLogs/test_vpc_router_nics_N1CDIU/results.txt (END)
```
The "test_02_redundant_VPC_default_routes" is expected to fail. I already
mentioned the bug above
I will add a separate report for the other tests as soon as they are ready.
Cheers,
Wilder
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
