Github user DaanHoogland commented on a diff in the pull request: https://github.com/apache/cloudstack/pull/1196#discussion_r47431643 --- Diff: plugins/hypervisors/xenserver/test/com/cloud/hypervisor/xenserver/resource/CitrixHelperTest.java --- @@ -0,0 +1,35 @@ +package com.cloud.hypervisor.xenserver.resource; + +import junit.framework.Assert; +import org.junit.Test; + +import static org.junit.Assert.*; --- End diff -- import * is not accepted per the style guidelines enforced by checkstyle. please replace. ``` [INFO] Starting audit... /Users/daan/cloudstack/cloudstack/plugins/hypervisors/xenserver/test/com/cloud/hypervisor/xenserver/resource/CitrixHelperTest.java:6: Using the '.*' form of import should be avoided - org.junit.Assert.*. Audit done. ``` hence ``` [INFO] ------------------------------------------------------------------------ [INFO] BUILD FAILURE [INFO] ------------------------------------------------------------------------ [INFO] Total time: 07:29 min [INFO] Finished at: 2015-12-12T14:18:54+01:00 [INFO] Final Memory: 93M/788M [INFO] ------------------------------------------------------------------------ [ERROR] Failed to execute goal org.apache.maven.plugins:maven-checkstyle-plugin:2.11:check (cloudstack-checkstyle) on project cloud-plugin-hypervisor-xenserver: Failed during checkstyle execution: There are 1 checkstyle errors. -> [Help 1] ```
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. ---