Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1273#issuecomment-167540899
@nitin-maharana I did not notice that the other PR was to 4.6, I thought it
was to master.
I would just ask you to use a Javadoc block over
âgetVolumeNameFromCommandâ instead of a commenting block.
At line 487, it is good your code, but we can improve it. The code you
wrote is the same as using
âorg.apache.commons.lang.StringUtils.isBlank(str)â; therefore, I believe
you should use the method from âStringUtilsâ from Apache commons lang.
I also recommend you to remove the comments of lines: 362, 369, 376 and
383, those tests names are intuitive, so there is no need to add comment there.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
