Github user nitin-maharana commented on the pull request:
https://github.com/apache/cloudstack/pull/1273#issuecomment-167484496
@rafaelweingartner : Thanks for reviewing the change.
The reason to close the old PR is because it was merging with branch 4.6.
I started this PR a long days back when everything from 4.6 being merged
with master.
But now I dont know the same is happening or not.
I saw most of the recent PRs are created with merging request to master.
So, I opened a new PR with master. But I have given a reference to my old PR.
So that reviewers can see the conversation.
About the code change, if we will make "required=true", there will be a
mismatch in logic of UI and API. In UI, the field is optional. I will modify
the comments section. Thanks for suggesting.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
