Github user mike-tutkowski commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1319#discussion_r49493043
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -476,6 +476,25 @@ public VolumeVO doInTransaction(TransactionStatus
status) {
});
}
+ /**
+ * Retrieves the volume name from CreateVolumeCmd object.
+ *
+ * If the retrieved volume name is null, empty or blank, then A random
name
+ * will be generated using getRandomVolumeName method.
+ *
+ * @param cmd
+ * @return Either the retrieved name or a random name.
+ */
+ public String getVolumeNameFromCommand(CreateVolumeCmd cmd) {
+ String userSpecifiedName = cmd.getVolumeName();
+
+ if
(org.apache.commons.lang.StringUtils.isBlank(userSpecifiedName)) {
--- End diff --
The code LGTM (I did not test it...just reviewed the code). My only comment
is on this line. Curious why we don't provide the import at the top as is
standard in CloudStack. Not a big deal, but it makes it easier to see at a
glance what all packages are involved. Perhaps there is another StringUtils
being imported, so this had to be done here?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
