Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1293#discussion_r49713222
--- Diff:
engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java ---
@@ -821,9 +819,9 @@ protected boolean
handleDisconnectWithInvestigation(final AgentAttache attache,
try {
nextStatus = host.getStatus().getNextStatus(event);
} catch (final NoTransitionException ne) {
- /* Agent may be currently in status of Down, Alert,
Removed, namely there is no next status for some events.
- * Why this can happen? Ask God not me. I hate there was
no piece of comment for code handling race condition.
- * God knew what race condition the code dealt with!
+ /*
--- End diff --
@miguelaferreira If you extract the code from lines 819-827 to a method,
you could add that comment block to it as a Java doc, a method such as
âgetHostNextStatusâ would do. I would only suggest you to remove the
sarcastic bit of it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
