Github user miguelaferreira commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1293#discussion_r49728823
--- Diff:
engine/orchestration/src/com/cloud/agent/manager/AgentManagerImpl.java ---
@@ -821,9 +819,9 @@ protected boolean
handleDisconnectWithInvestigation(final AgentAttache attache,
try {
nextStatus = host.getStatus().getNextStatus(event);
} catch (final NoTransitionException ne) {
- /* Agent may be currently in status of Down, Alert,
Removed, namely there is no next status for some events.
- * Why this can happen? Ask God not me. I hate there was
no piece of comment for code handling race condition.
- * God knew what race condition the code dealt with!
+ /*
--- End diff --
@GabrielBrascher and @rafaelweingartner Although I appreciate your remarks
(especially the one about refactoring a method out of a bigger method), I'm not
sure if you realise I've just formatted this class, and fixed a few logging
messages. Therefore I won't really be maintaining the rest of the
functionality. I do encourage you two to make a PR with your improvements in
it. This is after all open-source and cooperation based.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
