Github user DaanHoogland commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/857#discussion_r49947012
  
    --- Diff: 
plugins/event-bus/rabbitmq/src/org/apache/cloudstack/mom/rabbitmq/RabbitMQEventBus.java
 ---
    @@ -507,6 +512,21 @@ public synchronized boolean stop() {
             return true;
         }
     
    +    //logic to deal with blocked connection. connections are blocked for 
example when the rabbitmq server is out of space. 
https://www.rabbitmq.com/connection-blocked.html
    --- End diff --
    
    The first sentence is super-fluent. I would suggest changing the rest to:
    ```
    /**
     * connections are blocked for example when the rabbitmq server is out of 
space. {@link https://www.rabbitmq.com/connection-blocked.html}
     */
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to