Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1357#discussion_r50616271
--- Diff: server/test/com/cloud/vpc/MockConfigurationManagerImpl.java ---
@@ -456,6 +456,15 @@ public void createDefaultSystemNetworks(long zoneId)
throws ConcurrentOperationE
}
/* (non-Javadoc)
+ * @see
com.cloud.configuration.ConfigurationManager#deleteDomainSpecificVirtualRanges(long)
+ */
+ @Override
--- End diff --
@ustcweizhou The method
"com.cloud.configuration.ConfigurationManager.deleteDomainSpecificVirtualRanges(long)"
does not exist. Could you please alter this?
I am wondering, why this is a "non-Javadoc"? In my point of view, it could
be a Javadoc block.
There is another point citing an inexistent method (at
"releaseAccountSpecificVirtualRanges" method which is referring to
"com.cloud.configuration.ConfigurationManager.deleteAccountSpecificVirtualRanges(long)").
Although this comment is out of this PR scope, I think that it would be nice
to take the opportunity.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
