Github user GabrielBrascher commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1357#discussion_r52021538
--- Diff: server/src/com/cloud/configuration/ConfigurationManagerImpl.java
---
@@ -4932,6 +4932,32 @@ public Domain getVlanDomain(long vlanId) {
return _networkOfferingDao.search(sc, searchFilter);
}
+ @Override
+ @DB
+ public boolean releaseDomainSpecificVirtualRanges(final long
domainId) {
+ final List<DomainVlanMapVO> maps =
_domainVlanMapDao.listDomainVlanMapsByDomain(domainId);
+ if (maps != null && !maps.isEmpty()) {
--- End diff --
@ustcweizhou Thanks for your changes, the code is ok, just one more thing.
Could you please change the condition (**maps != null && !maps.isEmpty()**)
for (**MapUtils.isEmpty(maps)**)?
Thanks
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
