Github user GabrielBrascher commented on the pull request:

    https://github.com/apache/cloudstack/pull/1360#issuecomment-174212703
  
    @ProjectMoon Could you please do the following changes (1, 2, 3 and 4)?
    
    **1** - create a method for the code between lines 672 and 676;
    **2** - create a Javadoc for the new method;
    **3** - add a test case for the new method.
    **4** - The same (steps 1, 2 and 3) for the code at lines 678-688.
    
    With that, the code would be clean, well documented and with tests specific 
for each logic flow (with and without advanced network).
    
    Thank you.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to