So, since some have directly (over IM etc) or indirectly have thrown allegations on me since I merged most of the PRs. Here is a list of those 12 PRs and answers on why they were merged on case-by-case basis. Please keep any further replies technical and to the specific PR, please point out and revert if needed:
1. https://github.com/apache/cloudstack/pull/1288 Enough LGTMs, JS related change and fix tested with UI screenshot from Remi. I personally looked at the diff and therefore then merged. 2. https://github.com/apache/cloudstack/pull/1274/files Enough LGTMs, a simple NPE fix one-liner. I personally thought we can cheat here and given Travis/Jenkins passed I merged it. 3. https://github.com/apache/cloudstack/pull/1261/files Enough LGTMs, the diff only removed unused variable leading to change in the constructor definition. Explicit integration tests are not necessary as it’d simply dead-code removal and as the simulator smoke tests passed with Travis/Jenkins passed so I merged it. 4. https://github.com/apache/cloudstack/pull/1048 Enough LGTMs. This change is related to a marvin test itself where it adds 2 new test methods — so no need to run regression integration test. The integration test result of the marvin test was shared in the comment. PR merged on this basis. 5. https://github.com/apache/cloudstack/pull/1044 Enough LGTMs and regression tests results (shared as attachments by Daan, in case someone missed), so merged. 6. https://github.com/apache/cloudstack/pull/969 Enough LGTMs and regression tests results (shared as attachments by Daan, in case someone missed), so merged. 7. https://github.com/apache/cloudstack/pull/855 Enough LGTMs and regression tests results by Remi, so merged. 8. https://github.com/apache/cloudstack/pull/831 Enough LGTMs and only text changes in API doc-string so merged given Travis/Jenkins passed. 9. https://github.com/apache/cloudstack/pull/830/files Enough LGTMs and NPE fixes, so no explicit integration tests required given Travis/Jenkins passed. 10. https://github.com/apache/cloudstack/pull/1256/files Enough LGTMs and simple Java OOP fix with Travis/Jenkins passed so merged this. I’m aware of this codebase. 11. https://github.com/apache/cloudstack/pull/1240 Enough LGTMs, the changes would require manual tests wrt usage server etc as well as confirmed in comments. I had seen the regression test result (of the new/modified marvin test wrt of the feature) so merged. The regression test suite does not include this among other tests. 12. https://github.com/apache/cloudstack/pull/1289 Enough LGTMs, this was a findbugs related fix. Travis/Jenkins passed on it and the findbugs mvn job result was shared to confirm that the fix works now. This was not merged by me. Regards. [ShapeBlue]<http://www.shapeblue.com> Rohit Yadav Software Architect , ShapeBlue d: | s: +44 203 603 0540<tel:|%20s:%20+44%20203%20603%200540> | m: +91 8826230892<tel:+91%208826230892> e: rohit.ya...@shapeblue.com | t: <mailto:rohit.ya...@shapeblue.com%20|%20t:> | w: www.shapeblue.com<http://www.shapeblue.com> a: 53 Chandos Place, Covent Garden London WC2N 4HS UK [cid:imagec3b5d1.png@4f59c4e1.4a840a5d] Shape Blue Ltd is a company incorporated in England & Wales. ShapeBlue Services India LLP is a company incorporated in India and is operated under license from Shape Blue Ltd. Shape Blue Brasil Consultoria Ltda is a company incorporated in Brasil and is operated under license from Shape Blue Ltd. ShapeBlue SA Pty Ltd is a company registered by The Republic of South Africa and is traded under license from Shape Blue Ltd. ShapeBlue is a registered trademark. This email and any attachments to it may be confidential and are intended solely for the use of the individual to whom it is addressed. Any views or opinions expressed are solely those of the author and do not necessarily represent those of Shape Blue Ltd or related companies. If you are not the intended recipient of this email, you must neither take any action based upon its contents, nor copy or show it to anyone. Please contact the sender if you believe you have received this email in error. Find out more about ShapeBlue and our range of CloudStack related services: IaaS Cloud Design & Build<http://shapeblue.com/iaas-cloud-design-and-build//> | CSForge – rapid IaaS deployment framework<http://shapeblue.com/csforge/> CloudStack Consulting<http://shapeblue.com/cloudstack-consultancy/> | CloudStack Software Engineering<http://shapeblue.com/cloudstack-software-engineering/> CloudStack Infrastructure Support<http://shapeblue.com/cloudstack-infrastructure-support/> | CloudStack Bootcamp Training Courses<http://shapeblue.com/cloudstack-training/>
