Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1361#issuecomment-176948581
It is better now.
I only have to point two things out.
1 â About the class âcom.cloud.storage.ImageStoreDetailsUtilâ that
you created. You are using static methods, and those static methods are using
âvariablesâ that you want to set using the spring suite. The way you did
will not work; to my knowledge, those attributes will not be set by spring. If
you want to set them with spring you should annotate the class with
â@componentâ, then the object will be in the spring life cycle, and those
attributes will be set properly. Of course, if you do that, remove the static
from those methods (getNfsVersionByUuid, getNfsVersion) and then you would have
to inject the "ImageStoreDetailsUtil" object into those classes that want to
use the âgetNfsVersionâ methods.
2 â The java doc you created for
âcom.cloud.storage.ImageStoreDetailsUtil.getNfsVersion(long)â is pretty
nice. I would like to see the same in
âcom.cloud.storage.ImageStoreDetailsUtil.getNfsVersionByUuid(String)â.
Moreover, I think those methods deserve some test case.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
