Github user GabrielBrascher commented on the pull request:
https://github.com/apache/cloudstack/pull/1365#issuecomment-177495811
@bhaisaab Thanks for the test and StringUtils fix.
**-** Could you please change the Access Levels of diskDeviceBusName and
diskChain from public to private (at class VirtualMachineDiskInfo)?
I asked for a Javadoc at the getControllerFromDeviceBusName() method
because at first I thought that it was a simple get of a private String, then I
saw the logic inside it.
I agree that the method is clean and easy to understand, so it is your
call. Maybe it would be interesting to change its name then.
As a javadoc I was expecting something simple as:
`/**Returns the diskDeviceBusName substring, with the index starting at
":"*/`
Thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
