Github user rafaelweingartner commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r58742032
--- Diff:
plugins/hypervisors/vmware/src/com/cloud/hypervisor/vmware/resource/VmwareResource.java
---
@@ -4729,6 +4729,17 @@ private VirtualMachineGuestOsIdentifier
translateGuestOsIdentifier(String cpuArc
return VirtualMachineGuestOsIdentifier.OTHER_GUEST;
}
+ private String translateGuestOsIdentifierEx(String cpuArchitecture,
String guestOs, String cloudGuestOs) {
+ if (cloudGuestOs != null) {
--- End diff --
What about inverting the logic here? So, we can reduce one if-inception.
If(cloudGuestOs == null){
return translateGuestOsIdentifier(cpuArchitecture, guestOs,
cloudGuestOs).value();
}
...the rest of the code that was initially inside the if.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
