Github user srikanteswartalluri commented on the pull request:

    https://github.com/apache/cloudstack/pull/1431#issuecomment-195391894
  
    @sneeladh @shivsg  Thanks for adding the tests, can you please run your 
code through pyflakes, pep8 and fix them ?
    
    $ pyflakes *.py
    nuageTestCase.py:52: 'attr' imported but unused
    nuageTestCase.py:324: undefined name 'startVirtualMachine'
    nuageTestCase.py:328: undefined name 'FAIL'
    nuageTestCase.py:335: undefined name 'stopVirtualMachine'
    nuageTestCase.py:341: undefined name 'FAIL'
    test_nuage_password_reset.py:21: 'VirtualMachine' imported but unused
    test_nuage_password_reset.py:21: 'PublicIPAddress' imported but unused
    test_nuage_password_reset.py:26: 'createTemplate' imported but unused
    test_nuage_password_reset.py:26: 'listVolumes' imported but unused
    test_nuage_password_reset.py:64: undefined name 'cleanup_resources'
    test_nuage_password_reset.py:72: undefined name 'list_volumes'
    test_nuage_password_reset.py:84: undefined name 'Template'
    test_nuage_password_reset.py:118: local variable 'vm_public_ip' is assigned 
to but never used
    test_nuage_password_reset.py:217: undefined name 'startVirtualMachine'



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to