Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1441#issuecomment-197970382
Ok @mike-tutkowski, now I believe I understand a little bit more of the
code.
You are reusing a method that already exist and returns the
StrategyPriority (you did not create that method to suffice your code). I was
misled by the name of the method, when I first saw it, I thought that the
method was used solely to check if it can or cannot proceed with the snapshot
when in fact it is used to do much more.
I believe "getSnapshotStrategy" would be a more suitable name.
Now that I understand what we have there, I am ok with that conditional as
it
is.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
