Github user rafaelweingartner commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1441#discussion_r56507303
  
    --- Diff: 
engine/storage/snapshot/src/org/apache/cloudstack/storage/snapshot/XenserverSnapshotStrategy.java
 ---
    @@ -279,7 +282,52 @@ public boolean deleteSnapshot(Long snapshotId) {
     
         @Override
         public boolean revertSnapshot(SnapshotInfo snapshot) {
    -        throw new CloudRuntimeException("revert Snapshot is not 
supported");
    +        if (canHandle(snapshot,SnapshotOperation.REVERT) == 
StrategyPriority.CANT_HANDLE) {
    --- End diff --
    
    What about changing this "canHandle" method to return a boolean if the 
snapshot can be handled, instead of a enum value?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to