Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1348#discussion_r56490248
--- Diff:
plugins/hypervisors/kvm/src/com/cloud/hypervisor/kvm/resource/wrapper/LibvirtMigrateCommandWrapper.java
---
@@ -190,4 +195,27 @@ Use VIR_DOMAIN_XML_SECURE (value = 1) prior to v1.0.0.
return new MigrateAnswer(command, result == null, result, null);
}
-}
\ No newline at end of file
+
+ /**
+ * This function assumes an qemu machine description containing a
single graphics element like
+ * <graphics type='vnc' port='5900' autoport='yes'
listen='10.10.10.1'>
+ * <listen type='address' address='10.10.10.1'/>
+ * </graphics>
+ * @param xmlDesc the qemu xml description
+ * @param target the ip address to migrate to
+ * @return the new xmlDesc
+ */
+ String replaceIpForVNCInDescFile(String xmlDesc, final String target) {
+ final int begin = xmlDesc.indexOf(GRAPHICS_ELEM_START);
--- End diff --
@bhaisaab that is out of scope I think. The node is under ACS control.
Adding a xml parser would be nice, I agree.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
