Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1430#issuecomment-200888647
The test output you mean was the one posted by @kiwiflyer ?
I had not reviewed this PR (sorry for that), but there are two (2) things
here that called my attention.
At class âAgent.javaâ lines, 230, 238 and 451, (despite being the very
same piece of code) I worry about the exception that is not being logged. I
mean, we will see that message, but the exception stack that might be useful
for debugging will not be logged.
Additionally, the code between lines 232 and 239, it seems that it might
occur an infinite loop there (before the commit the throw new
CloudRuntimeException would break it). I know that when we deal with a
connection to a resource, there are hundreds of things that can go wrong and
sometimes if we try once or twice it might solve the problem. However, a code
that may enter into an infinite loop with a hidden exception does not sound a
neat solution for me.
Would not it be better to retry a few times and then, if nothing changes,
let an exception happens to break that flow of execution?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
