Github user kiwiflyer commented on the pull request:
https://github.com/apache/cloudstack/pull/1430#issuecomment-200901622
I want to point out that this is taking care of the case where you have a
load balancer between the agents and the management server (see original issue
notes). I'm personally not convinced that letting an exception be thrown that
causes the agent to fail, that is most likely caused by an underlying network
connectivity issue is a great solution either. Tomcat doesn't get taken down,
so the agent container is functional, but the application is dead.
If a set number of retries is added, there has to be a clean termination of
the agent so some other health checking application can restart the agent,
without requiring manual intervention (very painful if you have lots of hosts).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
