Github user alexandrelimassantana commented on the pull request:
https://github.com/apache/cloudstack/pull/1451#issuecomment-201610435
@insom with this changes there is still one place where the applyConfigToVR
is not provided with this timeout parameter (line 183, same class). This
function is actually called only in those 2 places. If it comes to a state
where you will always supply the timeout, remove the one which doesn't require
you to.
Also, if you plan to always supply the timeout, a change into lines 378 and
379 would provide more coersion:
```Java
if (timeout < 120) {
timeout = 120;
}
```
into:
```Java
if (timeout < VRScripts.DEFAULT_EXECUTEINVR_TIMEOUT) {
timeout = VRScripts.DEFAULT_EXECUTEINVR_TIMEOUT;
}
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
