Github user pedro-martins commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1451#discussion_r57537243
--- Diff:
core/src/com/cloud/agent/resource/virtualnetwork/VirtualRoutingResource.java ---
@@ -180,7 +179,7 @@ private Answer applyConfig(NetworkElementCommand cmd,
List<ConfigItem> cfg) {
boolean finalResult = false;
for (ConfigItem configItem : cfg) {
long startTimestamp = System.currentTimeMillis();
- ExecutionResult result =
applyConfigToVR(cmd.getRouterAccessIp(), configItem);
+ ExecutionResult result =
applyConfigToVR(cmd.getRouterAccessIp(), configItem,
VRScripts.DEFAULT_EXECUTEINVR_TIMEOUT);
if (s_logger.isDebugEnabled()) {
long elapsed = System.currentTimeMillis() - startTimestamp;
s_logger.debug("Processing " + configItem + " took " +
elapsed + "ms");
--- End diff --
Hi @insom .
I know that this isn't your code but could you use String.format to create
the string that is used by logger?
It turns the code more readable than using multiple strings concatenation.
Ty.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
