Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1365#issuecomment-211359119
@swill , @bhaisaab
There are still questions to be addressed here. One example is the question
at âVolumeApiServiceImplâ line1857. Another one is at
âVolumeApiServiceImplâ line 1851.
There maybe more, some message were hidden due to code changes. This is a
huge PR, which makes it pretty hard to review and then to check the changes
that are being made (the ones that are consequences of code review). I think we
need more work here.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
