Github user bhaisaab commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1365#discussion_r60095074
--- Diff: server/src/com/cloud/storage/VolumeApiServiceImpl.java ---
@@ -1835,6 +1847,26 @@ private Volume orchestrateDetachVolumeFromVM(long
vmId, long volumeId) {
}
}
+ public void updateMissingRootDiskController(final VMInstanceVO vm,
final String rootVolChainInfo) {
+ if (vm == null || !vm.getType().equals(VirtualMachine.Type.User)
|| Strings.isNullOrEmpty(rootVolChainInfo)) {
--- End diff --
@rafaelweingartner we'll get NPE anyway, we'll have to check vm != null as
in what you've suggested we're doing equals against vm.getType() (therefore
vm!=null check needed here).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
