Github user swill commented on the pull request:

    https://github.com/apache/cloudstack/pull/1420#issuecomment-212040090
  
    @bhaisaab I think you are being too hard on @rafaelweingartner.  He simply 
asked a question because the format was presented differently in two different 
files in the same PR.  It is a valid question and since you are the developer, 
you are the best person to explain this decision.  @rafaelweingartner has been 
doing a great job helping with code review and overreactions to questions like 
this will not make him want to review your code.  If he is not reviewing your 
code then you will have to find other people to review it for you.  We have a 
very limited number of people reviewing code right now, so if you want your PRs 
to get merged you need to make sure you are supportive of the people taking 
their time to review your work.  Please try to be more respectful in helping us 
understand the context for your decisions.  You are both valuable contributors 
so it is important for the community that you are able to be constructive in 
working together.
    
    Everyone step back, take a minute and come back with a constructive 
mindset...
    
    I think with @rafaelweingartner's LGTM, this PR is ready to merge...  Yes?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to