Github user bhaisaab commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1502#discussion_r60727764
  
    --- Diff: api/src/org/apache/cloudstack/api/response/ZoneResponse.java ---
    @@ -233,6 +234,9 @@ public void addTag(ResourceTagResponse tag) {
         }
     
         public void setResourceDetails(Map<String, String> details) {
    -        this.resourceDetails = details;
    +        if (details == null) {
    --- End diff --
    
    yes, if its null no point in setting it as nothing will be marshaled by 
gson/xml processor, also we don't want to consume the map but create a new copy 
out of it to avoid polluting user's datastructures


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to