Github user rafaelweingartner commented on the pull request:
https://github.com/apache/cloudstack/pull/1518#issuecomment-214868283
@nvazquez , what about extracting that âprivate Integer nfsVersionâ to
a common superclass to all of those command class? I have created a hierarchy
to help you. The classes with an * are the ones that you did not touch
directly, they are there just to build the hierarchy. I found a little odd that
the âListTemplateCommandâ received those values too, are they being used
there?
Maybe you cannot write a single super class to attend all of those cases,
but you could easily write on to be the super class for (CopyVolumeCommand,
SecStorageSetupCommand, GetStorageStatsCommand, SnapshotCommand,
BackupSnapshotCommand , CreatePrivateTemplateFromSnapshotCommand,
CreatePrivateTemplateFromVolumeCommand, CreateVolumeFromSnapshotCommand)
Here is the hierachy:
- TemplateOrVolumePostUploadCommand
- Command*
-- StorageCommand*
--- ListTemplateCommand
-- SsCommand*
--- AbstractDownloadCommand*
---- PrimaryStorageDownloadCommand
-- CopyVolumeCommand
-- SecStorageSetupCommand
-- GetStorageStatsCommand
-- SnapshotCommand
--- BackupSnapshotCommand
--- CreatePrivateTemplateFromSnapshotCommand
--- CreatePrivateTemplateFromVolumeCommand
--- CreateVolumeFromSnapshotCommand
I missing the test cases for
âcheckStorageProcessorAndHandlerNfsVersionAttributeâ,
âexamineStorageSubSystemCommandNfsVersionâ,
âsetCurrentNfsVersionInProcessorAndHandlerâ ,
âgetStorageNfsVersionFromNfsTOâ and âreconfigureNfsVersionâ methods.
They are very good coded, clean, short, well documented. To improve them
further the writing of test cases is very welcome.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
