Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1518#discussion_r61756086
--- Diff:
plugins/hypervisors/vmware/test/com/cloud/hypervisor/vmware/resource/VmwareResourceTest.java
---
@@ -117,4 +154,79 @@ public void testStartVm3dgpuEnabled() throws Exception{
verify(vmMo3dgpu).configureVm(any(VirtualMachineConfigSpec.class));
}
-}
+ //
---------------------------------------------------------------------------------------------------
+
+ @Test
+ public void testgetNfsVersionFromNfsTONull(){
+ assertFalse(_resource.getStorageNfsVersionFromNfsTO(null));
+ }
+
+ @Test
+ public void testgetNfsVersionFromNfsTONfsVersionNull(){
+
when(srcDataNfsTO.getNfsVersion()).thenReturn(NFS_VERSION_NOT_PRESENT);
+ assertFalse(_resource.getStorageNfsVersionFromNfsTO(srcDataNfsTO));
+ }
+
+ @Test
+ public void testgetNfsVersionFromNfsTONfsVersion(){
+ assertTrue(_resource.getStorageNfsVersionFromNfsTO(srcDataNfsTO));
+ }
+
+ //
---------------------------------------------------------------------------------------------------
+
+ @Test
+ public void testSetCurrentNfsVersionInProcessorAndHandler(){
+ _resource.setCurrentNfsVersionInProcessorAndHandler();
+ verify(storageHandler).reconfigureNfsVersion(any(Integer.class));
+ }
+
+ //
---------------------------------------------------------------------------------------------------
+
+ @Test
+ public void testExamineStorageSubSystemCommandNfsVersionNotPresent(){
+
when(srcDataNfsTO.getNfsVersion()).thenReturn(NFS_VERSION_NOT_PRESENT);
+ _resource.examineStorageSubSystemCommandNfsVersion(storageCmd);
+ verify(_resource,
never()).setCurrentNfsVersionInProcessorAndHandler();
+ }
+
+ @Test
+ public void testExamineStorageSubSystemCommandNfsVersion(){
+ _resource.examineStorageSubSystemCommandNfsVersion(storageCmd);
+ verify(_resource).setCurrentNfsVersionInProcessorAndHandler();
+ }
+
+ //
---------------------------------------------------------------------------------------------------
+
+ @Test
+ public void testStorageSetNfsVersion(){
--- End diff --
@rafaelweingartner @cristofolini
The idea was testing that once a version is set it cannot be changed later,
but as you mentioned below I tryied testing the whole flow, instead of the
method. I liked @cristofolini recommendation, I'll work on it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
