Github user rafaelweingartner commented on the pull request:

    https://github.com/apache/cloudstack/pull/1466#issuecomment-215546030
  
    @nvazquez, 
    What does that mean?
    
    First we are executing all of the `schema-XXXtoYYY.sql`, then all of the 
`schemaXXXtoYYY-cleanup.sql`? Instead of` schema-XXXtoYYY.sql, 
schemaXXXtoYYY-cleanup.sql` and then `schema-XXX+1toYYY+1.sql, 
schemaXXX+1toYYY+1-cleanup.sql`
    
    I have just looked at the code at 
"com.cloud.upgrade.DatabaseUpgradeChecker.upgrade(String, String)", that is 
exactly what happens.
    First we are executing all of the `schema-XXXtoYYY.sql`, then all of the 
`schemaXXXtoYYY-cleanup.sql`
    
    So, I am ok with your changes to create the "schema-410to420-cleanup.sql"
    
    So, I am ok with you moving some scripts to 



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to