GitHub user mike-tutkowski opened a pull request:

    https://github.com/apache/cloudstack/pull/1528

    CLOUDSTACK-9373: Class methods over-shawdowing instance methods

    We have some methods in base.py that are named the same.
    
    Per my findings below, Python methods in a class should not be named the 
same even if one is a class method and the other is an instance method.
    
    The solution discussed on dev@ is to remove the instance versions (reason 
listed in e-mail text, which is listed in JIRA ticket).
    
    https://issues.apache.org/jira/browse/CLOUDSTACK-9373

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mike-tutkowski/cloudstack marvin_methods

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cloudstack/pull/1528.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1528
    
----
commit f8fd382c9f8fe528b3dc98fde275daab98723de5
Author: Mike Tutkowski <mike.tutkow...@solidfire.com>
Date:   2016-05-02T21:23:56Z

    CLOUDSTACK-9373: Removing a few instance methods where there are class 
methods that are overshadowing them

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to