Github user rhtyd commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/872#discussion_r62172409
  
    --- Diff: systemvm/patches/debian/config/opt/cloud/bin/configure.py ---
    @@ -542,11 +552,11 @@ def configure_ipsec(self, obj):
                 secret.commit()
                 file.commit()
                 logging.info("Configured vpn %s %s", leftpeer, rightpeer)
    -            CsHelper.execute("ipsec auto --rereadall")
    -            CsHelper.execute("ipsec auto --add vpn-%s" % rightpeer)
    +            CsHelper.execute("ipsec reload")
    +            #CsHelper.execute("ipsec --add vpn-%s" % rightpeer)
                 if not obj['passive']:
    -                CsHelper.execute("ipsec auto --up vpn-%s" % rightpeer)
    -        os.chmod(vpnsecretsfile, 0o400)
    +                CsHelper.execute("sudo nohup ipsec up vpn-%s &" % 
rightpeer)
    --- End diff --
    
    @jayapalu why are we using sudo nohup, I think the executing user should be 
root? Also, instead of using nohup why not use service ipsec start/stop etc?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to