Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1371#discussion_r62783468
  
    --- Diff: 
server/src/org/apache/cloudstack/network/topology/AdvancedNetworkVisitor.java 
---
    @@ -212,4 +214,20 @@ public boolean visit(final AdvancedVpnRules vpnRules) 
throws ResourceUnavailable
             // results accordingly
             return _networkGeneralHelper.sendCommandsToRouter(router, cmds);
         }
    +
    +    @Override
    +    public boolean visit(final QuaggaRules quaggaRules) throws 
ResourceUnavailableException {
    +        final VirtualRouter router = quaggaRules.getRouter();
    +
    +        final Commands cmds = new Commands(Command.OnError.Continue);
    +
    +        try {
    +            _commandSetupHelper.createQuaggaConfigCommand(router, 
quaggaRules.getVpcId(), cmds);
    +        } catch (BadCIDRException ex) {
    +            s_logger.warn("Failed to create Quagga config due to faulty 
cidr ");
    --- End diff --
    
    Please log the exception to support operational debugging.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to