Github user jburwell commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1371#discussion_r62782496
--- Diff: server/src/com/cloud/network/vpc/VpcManagerImpl.java ---
@@ -747,6 +810,67 @@ public VpcOffering updateVpcOffering(final long
vpcOffId, final String vpcOfferi
}
@Override
+ public CIDR[] getZoneSuperCidrList(final long zoneId) throws
BadCIDRException {
+ final String superCIDRList = _dcDao.getDetail(zoneId,
Params.SUPER_CIDR.name());
+ if (superCIDRList != null) {
+ String[] str_cidr_list = superCIDRList.split(",");
+ CIDR[] cidr_list = NetUtils.convertToCIDR(str_cidr_list);
+ if (!NetUtils.cidrListConsistency(cidr_list)) {
+ throw new InvalidParameterValueException("The cidr list is
not consistent " + Arrays.toString(cidr_list));
+ }
--- End diff --
As noted in earlier comments, please consider a CIDR custom collection type
and encapsulation of this logic in it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
