Github user nvazquez commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/1518#discussion_r63377708
--- Diff:
engine/storage/src/org/apache/cloudstack/storage/image/BaseImageStoreDriverImpl.java
---
@@ -79,6 +80,25 @@
VMTemplateZoneDao _vmTemplateZoneDao;
@Inject
AlertManager _alertMgr;
+ @Inject
+ ImageStoreDetailsDao _imageStoreDetailsDao;
+
+ private static final String NFS_VERSION_DETAILS_KEY = "nfs.version";
--- End diff --
@koushik-das sorry for late reply. A reason for defining nfs details in
`BaseImageStoreDriverImpl` was that as `CloudStackImageStoreDriverImpl` and
`SimulatorImageStoreDriverImpl` both extend it and they both return a NfsTO
instance on `getStoreTO` we would need that key at least for the 2 mentioned
classes. What would you suggest?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
