Github user koushik-das commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1518#discussion_r63494164
  
    --- Diff: 
engine/storage/src/org/apache/cloudstack/storage/image/BaseImageStoreDriverImpl.java
 ---
    @@ -79,6 +80,25 @@
         VMTemplateZoneDao _vmTemplateZoneDao;
         @Inject
         AlertManager _alertMgr;
    +    @Inject
    +    ImageStoreDetailsDao _imageStoreDetailsDao;
    +
    +    private static final String NFS_VERSION_DETAILS_KEY = "nfs.version";
    --- End diff --
    
    @nvazquez One way would be create an intermediate class for NFS based 
stores and derive CloudStackImageStoreDriverImpl and 
SimulatorImageStoreDriverImpl from that.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to