Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r63960701
--- Diff:
plugins/hypervisors/xenserver/src/com/cloud/hypervisor/xenserver/resource/CitrixResourceBase.java
---
@@ -5402,4 +5402,20 @@ public boolean
attachConfigDriveToMigratedVm(Connection conn, String vmName, Str
}
-}
+ public ExecutionResult copyFileInVm(String vmIp, File file, String
dest) {
+ final Connection conn = getConnection();
+ final String hostPath = "/tmp/";
+
+ s_logger.debug("Copying file to VM with ip " + vmIp + " using host
" + _host.getIp());
+ try {
+ SshHelper.scpTo(_host.getIp(), 22, _username, null,
_password.peek(), hostPath, file.getCanonicalPath(), null);
+ } catch (final Exception e) {
--- End diff --
please catch more specific exceptions
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
