Github user DaanHoogland commented on a diff in the pull request:
https://github.com/apache/cloudstack/pull/669#discussion_r63997069
--- Diff:
plugins/hypervisors/hyperv/src/com/cloud/hypervisor/hyperv/resource/HypervDirectConnectResource.java
---
@@ -594,6 +597,25 @@ private PlugNicAnswer execute(final PlugNicCommand
cmd) {
}
}
+ private CopyFileInVmAnswer execute(CopyFileInVmCommand cmd) {
+ File keyFile = getSystemVMKeyFile();
+ try {
+ File file = new File(cmd.getSrc());
+ if(file.exists()) {
+ if(file.isDirectory()) {
+ for (File f : FileUtils.listFiles(new
File(cmd.getSrc()), TrueFileFilter.INSTANCE, TrueFileFilter.INSTANCE)) {
+ SshHelper.scpTo(cmd.getVmIp(), 3922, "root",
keyFile, null, cmd.getDest(), f.getCanonicalPath(), null);
+ }
+ } else {
+ SshHelper.scpTo(cmd.getVmIp(), 3922, "root", keyFile,
null, cmd.getDest(), file.getCanonicalPath(), null);
+ }
+ }
+ } catch (Exception e) {
--- End diff --
I understand you are basing yourself on bad code. That does not make it a
good practice. Either the SshHelper should be refactored to some extend and the
possible IOException should be caught seperately. See my general comment to
this PR, please.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
