Github user jburwell commented on a diff in the pull request:

    https://github.com/apache/cloudstack/pull/1626#discussion_r73559749
  
    --- Diff: tools/appliance/definitions/systemvmtemplate/definition.rb ---
    @@ -27,15 +27,15 @@
     architectures = {
         :i386 => {
             :os_type_id => 'Debian',
    -        :iso_file => 'debian-7.9.0-i386-netinst.iso',
    -        :iso_src => 
'http://cdimage.debian.org/cdimage/archive/7.9.0/i386/iso-cd/debian-7.9.0-i386-netinst.iso',
    -        :iso_md5 => 'e101a11ddb31f85acef542df1a49bf57',
    +        :iso_file => 'debian-7.11.0-i386-netinst.iso',
    +        :iso_src => 
'http://cdimage.debian.org/cdimage/archive/7.11.0/i386/iso-cd/debian-7.11.0-i386-netinst.iso',
    +        :iso_md5 => '75055a694508f5b891038ec12d703c9e',
         },
         :amd64 => {
             :os_type_id => 'Debian_64',
    -        :iso_file => 'debian-7.9.0-amd64-netinst.iso',
    -        :iso_src => 
'http://cdimage.debian.org/cdimage/archive/7.9.0/amd64/iso-cd/debian-7.9.0-amd64-netinst.iso',
    -        :iso_md5 => '774d1fc8c5364e63b22242c33a89c1a3'
    +        :iso_file => 'debian-7.11.0-amd64-netinst.iso',
    +        :iso_src => 
'http://cdimage.debian.org/cdimage/archive/7.11.0/amd64/iso-cd/debian-7.11.0-amd64-netinst.iso',
    +        :iso_md5 => '096c1c18b44c269808bd815d58c53c8f'
    --- End diff --
    
    Would it be possible to extract these values to a properties/configuration 
file?  Separating data from code is not more hygenic, but it also reduces the 
risk of the change and makes it easier to inject new values for 
development/testing.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to